Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use results on fs module #191

Merged
merged 15 commits into from
Sep 12, 2023
Merged

feat!: use results on fs module #191

merged 15 commits into from
Sep 12, 2023

Conversation

gnkz
Copy link
Contributor

@gnkz gnkz commented Sep 7, 2023

Refactor the fs module to use results and errors.

Closes #169

Refactor the fs module to use results and errors.

Closes #169
@gnkz gnkz marked this pull request as draft September 7, 2023 01:39
@gnkz gnkz marked this pull request as ready for review September 7, 2023 19:55
src/_modules/Fs.sol Outdated Show resolved Hide resolved
src/_modules/Fs.sol Show resolved Hide resolved
Copy link
Contributor

@vdrg vdrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gnkz gnkz merged commit f2998a1 into main Sep 12, 2023
@gnkz gnkz deleted the feat/add-results-to-fs branch September 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Fs module to use Results
2 participants