Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add results to commands #179

Merged
merged 10 commits into from
Sep 5, 2023
Merged

feat!: add results to commands #179

merged 10 commits into from
Sep 5, 2023

Conversation

gnkz
Copy link
Contributor

@gnkz gnkz commented Sep 4, 2023

Add results to the commands module similar to the requests experimental module.

Resolves #168

gnkz added 3 commits September 4, 2023 15:10
Add results to the commands module similar to the requests experimental
module.
Copy link
Contributor

@vdrg vdrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but a few changes might be necessary

src/_modules/Commands.sol Outdated Show resolved Hide resolved
src/_modules/Commands.sol Outdated Show resolved Hide resolved
src/_modules/experimental/Request.sol Outdated Show resolved Hide resolved
src/_modules/experimental/Request.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@vdrg vdrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gnkz gnkz merged commit 9770c9e into main Sep 5, 2023
@gnkz gnkz deleted the feat/add-results-to-commands branch September 5, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Commands module to use Results
2 participants