Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Could we have a pre-push hook to run checks #73

Open
LoisSotoLopez opened this issue Jun 1, 2024 · 2 comments
Open

ci: Could we have a pre-push hook to run checks #73

LoisSotoLopez opened this issue Jun 1, 2024 · 2 comments

Comments

@LoisSotoLopez
Copy link
Contributor

Forgetting about running the Rebar3 check alias can happen to anyone and explicitly add on the README that we should always do that before contributing... I would forget anyway. Having a pre-push hook feels fair enough to me and would help on keeping the commit history cleaner.

@github-project-automation github-project-automation bot moved this to 📑 TODO in erf Jun 1, 2024
@LoisSotoLopez
Copy link
Contributor Author

Also, for people not wanting to fix whatever might make the check fail, there's an option ( 🧙‍♂️ that I will not name here) for git push to skip pre-push hooks.

@javiergarea
Copy link
Member

I've been thinking about this for a while and would avoid it, at least for now. I've read several online discussions on the pros and cons and found no compelling reasons to add pre-push hooks to the repo. As we are a little team of contributors, I would suggest that each one maintain its hooks, at least for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📑 TODO
Development

No branches or pull requests

2 participants