Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax dependency conditions + increase dependencies #8

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Relax dependency conditions + increase dependencies #8

merged 4 commits into from
Nov 15, 2024

Conversation

ndaelman-hu
Copy link
Contributor

No description provided.

@ndaelman-hu ndaelman-hu added the enhancement New feature or request label Nov 15, 2024
@ndaelman-hu ndaelman-hu self-assigned this Nov 15, 2024
@coveralls
Copy link

coveralls commented Nov 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11859915043

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.98%
Totals Coverage Status
Change from base Build 10815577404: 0.0%
Covered Lines: 290
Relevant Lines: 392
💛 - Coveralls

@ndaelman-hu
Copy link
Contributor Author

@blueraft Should we consider referring to nomad-lab[dev] rather than specifying them separately here?

@blueraft
Copy link

I think it's better to specify your own dev dependencies here, nomad-lab[dev] would bring in way too many dependencies.

@ndaelman-hu ndaelman-hu merged commit d4e7393 into develop Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueraft blueraft blueraft approved these changes

@ladinesa ladinesa Awaiting requested review from ladinesa

Assignees

@ndaelman-hu ndaelman-hu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndaelman-hu @coveralls @blueraft