Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThumbsOptions incorrect types #7421

Labels
t0ggles Linked to the t0ggles task

Comments

@dvdmlln
Copy link

dvdmlln commented Mar 26, 2024

Check that this is really a bug

  • I confirm

Reproduction link

Bug description

I'm using Vue with Swiper Element and define SwiperOptions in my vue setup using SwiperOptions Type form swiper/types. Then I use v-bind to pass the attributes as props.
thumbs.swiper requires the type Swiper | null, so passing a CSS Selector obviously throws the following type error: Type 'string' is not assignable to type 'Swiper'., but the thumbs do work.
So the thumbs.swiper type should be Swiper | string | null instead.
This may also effect other options.

Expected Behavior

No response

Actual Behavior

No response

Swiper version

11.0.6

Platform/Target and Browser Versions

all

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@nolimits4web
Copy link
Owner

t0ggles-create swiper

Copy link

t0ggles bot commented Mar 28, 2024

Task nolimits4web/SWIPER-83 was created

t0ggles task SWIPER-83

@t0ggles t0ggles bot added the t0ggles Linked to the t0ggles task label Mar 28, 2024
Copy link

t0ggles bot commented Mar 28, 2024

Task nolimits4web/SWIPER-83 status changed to Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment