Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count aria-label without duplicated item in loop option #4781

Closed
6 tasks done
digitas-git opened this issue Jul 21, 2021 · 0 comments
Closed
6 tasks done

Count aria-label without duplicated item in loop option #4781

digitas-git opened this issue Jul 21, 2021 · 0 comments

Comments

@digitas-git
Copy link

digitas-git commented Jul 21, 2021 •
edited
Loading

Check that this is really a bug

  • I confirm

Reproduction link

https://swiperjs.com/demos#infinite-loop

Bug description

If the loop option is set, the aria-label count all DOM elements including the duplicated. There are 5 elements, but 7 are counted by the duplicates.

Expected Behavior

If the loop option is set, the aria label may only be attached to the non-duplicated elements. Only the elements that are not duplicated are counted.

Actual Behavior

No response

Swiper version

6.7.0

Platform/Target and Browser Versions

Independent of platform/browser

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(a11y): Count aria-label without duplicated item in loop option digitas-git/swiper
1 participant
@digitas-git