Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: allow disabling slideRole #5838

Merged
merged 1 commit into from
Jul 1, 2022
Merged

a11y: allow disabling slideRole #5838

merged 1 commit into from
Jul 1, 2022

Conversation

huubl
Copy link
Contributor

@huubl huubl commented Jun 30, 2022

I want to add the slides as ul > li like in this W3C example.

<ul className="swiper-wrapper" [..]>
  <li className="swiper-slide" [..]>
    [..]
  </li>
</ul>

Now I have to set slideRole: 'listitem', which is redundant. This allows setting slideRole to null.

@nolimits4web nolimits4web merged commit b376aa1 into nolimits4web:master Jul 1, 2022
@huubl huubl deleted the allow-disabling-sliderole branch July 1, 2022 13:01
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huubl @nolimits4web