fix(pagination): formatter functions now accept strings as return values #5610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both
formatFractionCurrent
andformatFractionTotal
accept only callbacks which return a number. This makes it impossible write functions like this when using TypeScript (without usingany
):The above code produces this error:
Type '(number: number) => string' is not assignable to type '(number: number) => number'.
Since the values returned by theese functions are directly used inside the DOM7 elements
.text()
functions (see this and this line) it's safe to change the function signatures.