Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): formatter functions now accept strings as return values #5610

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

Lehoczky
Copy link
Contributor

@Lehoczky Lehoczky commented Apr 5, 2022

Currently both formatFractionCurrent and formatFractionTotal accept only callbacks which return a number. This makes it impossible write functions like this when using TypeScript (without using any):

pagination: {
  el: '#swiper',
  formatFractionCurrent(number) {
      const formatter = new Intl.NumberFormat('en-US', { ... })
      return formatter.format(number)
  },
},

The above code produces this error: Type '(number: number) => string' is not assignable to type '(number: number) => number'.

Since the values returned by theese functions are directly used inside the DOM7 elements .text() functions (see this and this line) it's safe to change the function signatures.

@nolimits4web nolimits4web merged commit 629c1c4 into nolimits4web:master Apr 6, 2022
@nolimits4web
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants