fix(angular): deprecate [(index)] and setIndex() (#4951)

nolimits4web · Sep 13, 2021 · 7ee3d58 · 7ee3d58
1 parent 6c0a3e5
commit 7ee3d58
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/playground/angular/src/app/home/home.component.html b/playground/angular/src/app/home/home.component.html
@@ -114,7 +114,6 @@ <h3>Custom pagination</h3>
       [breakpoints]="breakpoints"
       [scrollbar]="scrollbar"
       [loop]="true"
-      [(index)]="indexNumber"
       [pagination]="{ el: '.swiper-pagination.pagination-test' }"
     >
       <ng-container *ngIf="show">
@@ -134,11 +133,6 @@ <h3>Custom pagination</h3>
     <button (click)="toggleScrollbar()">Toggle scrollbar</button>
     <button (click)="breakpointChange()">Breakpoint change</button>
     <button (click)="show = !show">Toggle show</button>
-    <button (click)="indexNumber = 0">0</button>
-    <button (click)="indexNumber = 3">3</button>
-    <button (click)="indexNumber = 5">5</button>
-    <button (click)="indexNumber = 6">6</button>
-    {{ indexNumber }}
 
     <swiper [config]="exampleConfig">
       <ng-template swiperSlide>Best slide ever 2</ng-template>

diff --git a/playground/angular/src/app/home/home.component.ts b/playground/angular/src/app/home/home.component.ts
@@ -56,7 +56,6 @@ export class HomePage {
     this.controlledSwiper = swiper;
   }
 
-  indexNumber = 1;
   exampleConfig = { slidesPerView: 3 };
   slidesPerView: number = 4;
   pagination: any = false;

diff --git a/src/angular/src/swiper.component.ts b/src/angular/src/swiper.component.ts
@@ -234,6 +234,7 @@ export class SwiperComponent implements OnInit {
 
   @Input()
   set index(index: number) {
+    console.warn('`[(index)]` prop is deprecated and will be removed in upcoming versions');
     this.setIndex(index);
   }
   @Input()
@@ -821,8 +822,11 @@ export class SwiperComponent implements OnInit {
     } else {
       this.swiperRef.params[_key] = value;
     }
+    this.setIndex(2);
   }
-
+  /**
+   * @deprecated will be removed in upcoming versions
+   */
   setIndex(index: number, speed?: number, silent?: boolean): void {
     if (!this.isSwiperActive) {
       this.initialSlide = index;