[PR] Provide helpers to combine few callbacks for body-/meta-filters

[kopf-archiver]

A pull request by nolar at 2020-04-07 18:56:43+00:00
Original URL: zalando-incubator/kopf#345
Merged by nolar at 2020-04-08 14:52:30+00:00

What do these changes do?

Little helpers to combined few callbacks for when= or labels/annotations filters.

Description

Nothing more that a little bit of syntax sugar with kopf.all_() and kopf.any_():

import kopf

def whole_fn1(name, **_): return name.startswith('kopf-')
def whole_fn2(spec, **_): return spec.get('field') == 'value'
def value_fn1(value, **_): return value.startswith('some')
def value_fn2(value, **_): return value.endswith('label')

@kopf.on.create('zalando.org', 'v1', 'kopfexamples',
                when=kopf.all_([whole_fn1, whole_fn2]),
                labels={'somelabel': kopf.all_([value_fn1, value_fn2])})
def create_fn1(**_):
    pass

@kopf.on.create('zalando.org', 'v1', 'kopfexamples',
                when=kopf.any_([whole_fn1, whole_fn2]),
                labels={'somelabel': kopf.any_([value_fn1, value_fn2])})
def create_fn2(**_):
    pass

Based on the experience when few arbitrary criteria should be combined onto one criterion, but it looks ugly to add too many one-liner single-use functions that call real meaningful functions with and/or operators.

Issues/PRs

Issues: #123 #98

Type of changes

• New feature (non-breaking change which adds functionality)

Checklist

• The code addresses only the mentioned problem, and this problem only
• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt