Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Better naming for timeouts + connection timeout #337

Closed
5 tasks done
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
5 tasks done

[PR] Better naming for timeouts + connection timeout #337

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive enhancement New feature or request

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2020-03-27 21:48:24+00:00
Original URL: zalando-incubator/kopf#337
Merged by nolar at 2020-03-29 23:28:50+00:00

What do these changes do?

Follow-ups for #336 with better naming of the timeout settings.

Description

#336 was merged but not released yet, so it is fine to quickly change the names without backward compatibility implemented.

In addition, a connection timeout is added for watching streams — to distinguish it from the total timeout on the client side (which is supposed to be infinite in a perfect world). The connection timeout is needed to handle the cases of broken networking in some cluster setups — for which kopf.config.WatchersConfig.session_timeout was originally introduced in #322 .

Issues/PRs

Issues: #23

Related: #322 #192 #109

Type of changes

  • New feature (non-breaking change which adds functionality)
  • Mostly documentation and examples (no code changes)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Better naming for timeouts + connection timeout Aug 19, 2020
@kopf-archiver kopf-archiver bot added the enhancement New feature or request label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

0 participants