Force echo to enable "\." expansion for title escape sequences #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkkolos
referenced
this pull request
Dec 16, 2015
"echo -e" was necessary when colors were defined with "\e". But we have abandonned this years ago. It was time to fix this! We now use "echo -E" to force echo to disable "\." expansion.
dolmen
added a commit
that referenced
this pull request
Dec 16, 2015
With 50ace41 I broke _lp_title as the TITLE_OPEN/TITLE_CLOSE had content that required expansion (echo -e). This caused an issue only on zsh because for bash \e in PS1 was expanded (not in zsh because escape sequences use '%' instead of '\'). The issue is now fixed by using raw bytes in TITLE_OPEN/TITLE_CLOSE. (Thanks to pkkolos for also noticing the issue and reporting it)
|
The issue only had consequences in zsh. I fixed it with a2f7a3a. |
pkkolos
pushed a commit
to pkkolos/liquidprompt
that referenced
this pull request
Dec 17, 2015
With 50ace41 I broke _lp_title as the TITLE_OPEN/TITLE_CLOSE had content that required expansion (echo -e). This caused an issue only on zsh because for bash \e in PS1 was expanded (not in zsh because escape sequences use '%' instead of '\'). The issue is now fixed by using raw bytes in TITLE_OPEN/TITLE_CLOSE. (Thanks to pkkolos for also noticing the issue and reporting it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP_TITLE_OPEN&LP_TITLE_CLOSEneed the "." expansion, so explicitly enable it.A screenshot:
