LP_HOSTNAME_ALWAYS=-1 to never show hostname #406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New change looks way more extensive than it is, since I wrapped a section in an "if" wrapper and had to increase the indentation level for everything in the block. |
dolmen
changed the title
|
Seems ok, except I would prefer to use the value |
dolmen
added
hostname
|
Value changed, commit message updated, and commits squashed. |
augmentedfourth
changed the title
|
Rebased over feature/FQDN merge |
dolmen
added
merged!
and removed
needs work
|
Thanks! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OS X, I've been having problems determining connection status, and often a local connection shows up as if it were Telnet (color: WARN_RED).
Instead of adding an LP_HOSTNAME_NEVER option, or changing the option name to LP_HOSTNAME and breaking existing configs, just added a value "2" that will prevent showing hostname at all.
I realize this is a hack, because I'd rather find out the terminal status properly, but I wasn't having much luck with that so this option will hopefully suffice for now.