Put 12 o'clock clock face at array index 0 #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was experiencing an issue on OS X Yosemite where the clock was always displaying an hour ahead. I think this fixed the issue, since 12 % 12 should equal 0, so I would expect the clock face for 12 o'clock to be at index 0. This seems to have fixed the issue for me.
|
Related to change made in #273. |
|
That's strange… this change is OK on my Mac (and the explanations are OK) but I remember that, without the changes of my commit, a wrong hour was displayed. So… all my apologies. |
|
Note to self: check if this is an array indexing issue (bash starts at 0, zsh starts at 1) |
|
My apologies… but I've just checked the last develop version and there is still a problem for me. On ZSH, local time (France) is 0:42 and i can't obtain an analog clock except if I replace the line by in _lp_time_analog. I think it's related to your last comment @dolmen. |
dolmen
added a commit
that referenced
this pull request
Nov 5, 2015
Thanks to @wprl for an alternate attempt at a fix. Thanks to @anthonygelibert for feedback.
|
This seems to be fixed by a976934. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing an issue on OS X Yosemite where the clock was always displaying an hour ahead. I think this fixed the issue, since 12 % 12 should equal 0, so I would expect the clock face for 12 o'clock to be at index 0. This seems to have fixed the issue for me.