git prompt broken for worktrees in v2.0 #658
Comments
|
I'm currently on vacation, so responses might be slow. Thanks for the clear report, and stupid simple reproduction steps. Yeah, this one is a bit embarrassing. I have always wanted to use workdirs more often, but have been too lazy to really learn how they work. As a self proclamed Git expert, I really should have already known. Anyway, good bisecting work. That commit moved away from using that 'is-work-tree' command all the time to determine if the current directory is a Git dir to instead looking for a '.git/' directory, since it is so much faster. But a workdir uses a '.git' file, so that match failed. I pushed the above commit to add a check for that. Could you give it a test? |
|
@andreimatei any chance to test commit fc44d97? |
|
Sorry for missing you previous message. The commit works. |
|
Fix released as part of v2.0.2. |
Git worktrees (see git worktree --help) are registered as .git _files_ instead of directories. This meant Liquidprompt would fail to detect them. Since other VCSs do not have similar files, add a special case for Git files like this. Fixes liquidprompt#658
I used to get the git prompt when I was in a worktree dir (
git worktree). Not any more; now it's as if I'm not inside a repo dir.I've bisected to f434b6d
FWIW,
git rev-parse --is-inside-work-treeproperly detects the worktree.It's easy to reproduce by creating a worktree (
git worktree add <path>; cd <path>).Thanks!
The text was updated successfully, but these errors were encountered: