-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add _lp_git_staged_lines and _lp_git_staged_files for themes #644
Comments
I am not completely sure I understand what you are asking for.
I think you are misunderstanding the code in This section will detect if a VCS provider supports a staging area (like Git) or not (like Mercurial), and if it does, show the diff to staging, and if not, show the diff to the last commit. Are you asking for the default theme to show both staged and uncommitted line counts? I doubt that many users would find that very helpful, and keeping the default theme the same as users have come to expect is important. But you are welcome to create a theme that does that. If you do, I would want to see it. Please correct me if I did not understand your request. |
After thinking about it, do not modify _lp_git_uncommitted_lines but maybe create a new :
Not to integrate it in the default LiquidPrompt but to use it in the theme |
I'm fine with that. I had considered adding a |
The linked PR is a proposed fix. Could you give it a try and see if it is what you were expecting? The docs for the new functions can be found here. |
I look this in WE. |
I considered making these when I did the overall VCS rework, but thought that since the default theme does not use it, it was pointless. But now that a user has requested it, why not. Fixes liquidprompt#644
Description
Hello, i customize a power line theme and i has surprise by the base commend git for _lp_git_uncommitted_lines : is the addition of diff in working and stage.
maybe add _lp_git_staged_lines and _lp_git_staged_files for themes
How will this be useful?
Can use this for show diff line/file in working ant staging zone in same time
Example prompt
PS : with a little help i can make a PR
The text was updated successfully, but these errors were encountered: