Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misspelling variable name #564

Closed
liujoey opened this issue Feb 3, 2019 · 1 comment
Closed

misspelling variable name #564

liujoey opened this issue Feb 3, 2019 · 1 comment
Assignees
@dolmen

Comments

@liujoey
Copy link

liujoey commented Feb 3, 2019

https://github.com/nojhan/liquidprompt/blob/eda83efe4e0044f880370ed5e92aa7e3fdbef971/liquidprompt#L487

typeset _LP_ENABLE_DETACHED_SESSION here, but used _LP_ENABLE_DETACHED_SESSIONS elsewhere.

And typeset should have -x option, otherwise the _LP_ENABLE_SCREEN and _LP_ENABLE_TMUX value is not visible in function _lp_jobcount_color(). At least on my Mac OS Mojave, i have to add -x to the typeset to make this function work.
dolmen added a commit that referenced this issue Oct 16, 2019
@dolmen
Fix typo in variable name (#564)
d570666 
Thanks to Joey Liu (@liujoey) for the discovery.
dolmen added a commit that referenced this issue Oct 16, 2019
@dolmen
Fix typo in variable name (#564)
a2b86b9 
Thanks to Joey Liu (@liujoey) for the discovery.
@dolmen
Copy link
Collaborator

dolmen commented Oct 16, 2019

Thanks for the catch! Fixed.

@dolmen dolmen self-assigned this Oct 16, 2019
pkkolos pushed a commit to pkkolos/liquidprompt that referenced this issue Oct 17, 2019
@dolmen
Fix typo in variable name (liquidprompt#564)
330415d 
Thanks to Joey Liu (@liujoey) for the discovery.
@Rycieos Rycieos closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dolmen dolmen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liujoey @dolmen @Rycieos