Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OS X] Incorrectly detects a local session as telnet #407

Closed
daverigby opened this issue Nov 13, 2015 · 4 comments
Closed

[OS X] Incorrectly detects a local session as telnet #407

daverigby opened this issue Nov 13, 2015 · 4 comments
Labels
bug MacOS X Related to MacOS X specific implementation

Comments

@daverigby
Copy link

See #304 (comment) - as of commit 0d7d3fd the hostname is incorrectly detected as telnet.

Environment: OS X 10.11 (El Capitan).

@nedbat
Copy link

nedbat commented Nov 14, 2015

This is also happening to me on Yosemite. This is the output of the commands you're using to decide:

$ LANG=C who am i
ned      ttys004  Nov 14 08:08
$ ps -o comm= -p $PPID 2> /dev/null
login

@dolmen dolmen added release blocker An issue that must be resolved before the next release is ready bug MacOS X Related to MacOS X specific implementation labels Nov 30, 2015
@dolmen
Copy link
Collaborator

dolmen commented Nov 30, 2015

Please try the fix-407 branch: 119477c

@nedbat
Copy link

nedbat commented Dec 6, 2015

The fix-407 branch works properly for me.

@dolmen
Copy link
Collaborator

dolmen commented Dec 7, 2015

The fix-407 branch works properly for me.

Great! I've merged the commit on develop with cf015ea.

@dolmen dolmen closed this as completed Dec 7, 2015
@dolmen dolmen removed the release blocker An issue that must be resolved before the next release is ready label Dec 7, 2015
pkkolos pushed a commit to pkkolos/liquidprompt that referenced this issue Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug MacOS X Related to MacOS X specific implementation
Projects
None yet
Development

No branches or pull requests

3 participants