Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pwd is displayed wrong when it contains a $ char #389

Closed
dserodio opened this issue Aug 20, 2015 · 1 comment
Closed

pwd is displayed wrong when it contains a $ char #389

dserodio opened this issue Aug 20, 2015 · 1 comment
Labels
bug path Related to current working directory lookup or display release blocker An issue that must be resolved before the next release is ready

Comments

@dserodio
Copy link

We have some buggy scripts which create directories containing $ characters. When inside one of these directories, the current directory shown by liquidprompt is wrong:

[/tmp] $ mkdir '$foo'
[/tmp] $ cd '$foo'
[/tmp/] $ pwd
/tmp/$foo
@dolmen dolmen added bug path Related to current working directory lookup or display labels Aug 26, 2015
@dolmen dolmen added the release blocker An issue that must be resolved before the next release is ready label Jan 9, 2016
@dolmen
Copy link
Collaborator

dolmen commented Jan 9, 2016

Confirming this bug is still in develop b53e53b on bash.
On zsh we have issue with \ in directory names.

dolmen added a commit that referenced this issue Jan 12, 2016
@dolmen
Rewrite _lp_escape, and use it for LP_PWD in lp_shorten_path #389
74e14fe 
This should fix '$' or '\' in pwd (#389)
TODO: set ALL shell options that affect PS1 evaluation.

Remaining broken case in zsh: '\b' (and '\n'...) in pwd
dolmen added a commit that referenced this issue Jan 12, 2016
@dolmen
Merge branch 'fix/389-escape-special-chars' into develop
3a66c7a 
Issue #389 almost fixed.
Remaining failing case on zsh: 'mkdir a\\b; cd a\\b'
pkkolos pushed a commit to pkkolos/liquidprompt that referenced this issue Jan 23, 2016
@dolmen
Rewrite _lp_escape, and use it for LP_PWD in lp_shorten_path liquidpr…
2d53a4a 
…ompt#389

This should fix '$' or '\' in pwd (liquidprompt#389)
TODO: set ALL shell options that affect PS1 evaluation.

Remaining broken case in zsh: '\b' (and '\n'...) in pwd
@dolmen dolmen closed this as completed in ae854bf May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug path Related to current working directory lookup or display release blocker An issue that must be resolved before the next release is ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dolmen @dserodio