bzr: "number expected"

[aboettger]

terminal shows this

_lp_bzr_branch_color:15: number expected

in a bzr folder

[dolmen]

Which branch do you use? master? develop?
Which shell do you use? bash? zsh?

[aboettger]

shell: zsh
branch: master

[chase]

I can't say zsh gives the most descriptive errors, but this is caused by line 1066 of liquidprompt, line 15 of _lp_bzr_branch_color.

This is valid in bash, but not zsh, for two reasons:

1. Arrays cannot be directly assigned in a local. zsh interprets parenthesis on a local assign as a glob.
2. Words are not split as arrays in zsh unless the option sh_word_split is set.

Here is a quick patch that I made:

diff --git a/liquidprompt b/liquidprompt
index e914b49..63952b3 100755
--- a/liquidprompt
+++ b/liquidprompt
@@ -1063,7 +1063,10 @@ _lp_bzr_branch_color()
     local output
     output="$(bzr version-info --check-clean --custom --template='{branch_nick} {revno} {clean}' 2> /dev/null)"
     [[ $? -ne 0 ]] && return
-    local tuple=($output)
+    $_LP_SHELL_zsh && setopt local_options && setopt sh_word_split
+    local tuple
+    tuple=($output)
+    $_LP_SHELL_zsh && unsetopt sh_word_split
     local branch=${tuple[_LP_FIRST_INDEX+0]}
     local revno=${tuple[_LP_FIRST_INDEX+1]}
     local clean=${tuple[_LP_FIRST_INDEX+2]}

I'm not 100% sure that is valid bash, but it certainly is valid (albeit ugly) zsh.

[dolmen]

Please try the develop branch: it got a few bazar related changes (see #227) (and many other fixes in general), and report if the issue still occurs.

[chase]

@dolmen, the development branch doesn't address the issue. It still has the guilty line.

[aboettger]

[aboettger]

chase, your patch works for me:

    $_LP_SHELL_zsh && setopt local_options && setopt sh_word_split
    local tuple
    tuple=($output)
    $_LP_SHELL_zsh && unsetopt sh_word_split

[dolmen]

Fixed by @chase in 89a71c1