Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different heights of projects cover #27

Open
lukmarcus opened this issue Feb 10, 2023 · 1 comment
Open

Different heights of projects cover #27

lukmarcus opened this issue Feb 10, 2023 · 1 comment
Assignees
Labels
bug Something isn't working Priority: Low

Comments

@lukmarcus
Copy link
Collaborator

Page: https://krzysztofszumny.com/projects

Desktop: Projects' covers have different heights and it look not very good. Different sizes of images?

Mobile: The same but projects are listed vertical so it's impossible to notice.

obraz

Desktop:
Firefox 109.0.1.
Chrome 110.0.5481.78.

Mobile:
Mozilla/5.0 (Linux; Android 11; SAMSUNG SM-G973U) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/14.2 Chrome/87.0.4280.141 Mobile Safari/537.36

@lukmarcus lukmarcus added the bug Something isn't working label Feb 10, 2023
@noisy noisy added this to Portfolio Feb 10, 2023
@noisy
Copy link
Owner

noisy commented Apr 7, 2023

In general, it would be good to adjust the styles so an image would be adjust to desired ratio. object-fit: cover comes to my mind: https://www.w3schools.com/css/css3_object-fit.asp

Probably it could be used to fix this. Then, perfect image ratio would not be required.

But if there is a better solution (for example bootstrap based, go for it!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: Low
Projects
Status: No status
Development

No branches or pull requests

2 participants