Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update grammar #46

Merged
merged 1 commit into from
Nov 18, 2023
Merged

feat: update grammar #46

merged 1 commit into from
Nov 18, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Nov 18, 2023

Description

Problem*

Resolves

Summary*

This PR updates the grammar to handle various new language features which we've added. It's not perfect (The & in &mut doesn't get highlighted for some reason) but it's a big improvement over the current.

Changes:

  • hex numbers now get consistently marked as a numeric literal rather than the letters remaining white.
  • impl, trait, type, unconstrained, distinct, pub, mut and self are marked as keywords.
  • true and false are now displayed as constants rather than as keywords.
  • removed the Witness type as it does not exist.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

BEGIN_COMMIT_OVERRIDE
feat: Update language grammar (#46)
END_COMMIT_OVERRIDE

@TomAFrench TomAFrench merged commit 85d3d4d into master Nov 18, 2023
2 checks passed
@TomAFrench TomAFrench deleted the tf/update-grammar branch November 18, 2023 11:13
@github-actions github-actions bot mentioned this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants