-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement LSP client #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't examine extension.ts in-depth but this looks generally like what I'd expect from an LSP skeleton.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bikeshedding but are you happy to use yarn for this? We tend to use this over npm in our other repos.
@TomAFrench Yarn probably makes sense since the rest of aztec uses it. I switched back to npm for personal projects awhile ago because yarn2/3 were so bad (new design requiring a custom patch for each typescript release). Npm added workspaces so it had everything I needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Problem*
Resolves #2
Summary*
This reorganizes the vscode extension and adds an LSP client to communicate with the Nargo LSP.
A lot has changed in the reorganization but this aligns the extension with the common/expected layout. Most of which was taken from the Grain vscode extension that I wrote, which in turn was based on the vscode example layout and documentation.
Additional Context
Prettier should be run on more code in the repo but it resulted in a ton of changes in this diff. We can do it separately.
PR Checklist*
cargo fmt
on default settings.