Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to noir_bignum v0.4.0 #10

Merged

Conversation

iAmMichaelConnor
Copy link
Collaborator

@iAmMichaelConnor iAmMichaelConnor commented Nov 3, 2024

Depends on noir-lang/noir-bignum#44 being merged, so that this Nargo.toml can point to a release version or main. (Currently the Nargo.toml points to that feature branch of bignum).

Updates bigcurve to be compatible with the latest bignum.

BEGIN_COMMIT_OVERRIDE
feat!: update to noir_bignum v0.4.0 (#10)

Release-as: v0.5.0
END_COMMIT_OVERRIDE

Nargo.toml Outdated
# bignum = {path = "../noir-bignum"}
# bignum = {tag = "v0.4.0", git = "https://github.com/noir-lang/noir-bignum"}
bignum = {tag = "mc/bignum-compatibility-changes", git = "https://github.com/noir-lang/noir-bignum"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO, once the bignum PR is merged.

@TomAFrench TomAFrench changed the title feat: update to be compatible with latest bignum feat!: update to be compatible with latest bignum Nov 8, 2024
@TomAFrench TomAFrench changed the title feat!: update to be compatible with latest bignum feat!: update to noir_bignum v0.4.0 Nov 8, 2024
@TomAFrench TomAFrench merged commit 3930699 into noir-lang:main Nov 8, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants