Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64url support #15

Closed
olehmisar opened this issue Oct 16, 2024 · 3 comments · Fixed by #24
Closed

Add base64url support #15

olehmisar opened this issue Oct 16, 2024 · 3 comments · Fixed by #24
Labels
enhancement New feature or request

Comments

@olehmisar
Copy link

Problem

I want to encode/decode a base64url string

Happy Case

I can encode/decode a base64url string

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

Nice-to-have

Blocker Context

No response

Would you like to submit a PR for this Issue?

Maybe

Support Needs

No response

@olehmisar olehmisar added the enhancement New feature or request label Oct 16, 2024
@saleel
Copy link
Contributor

saleel commented Oct 17, 2024

I believe @grjte is working on adding this.

@grjte
Copy link
Contributor

grjte commented Oct 18, 2024

Yep, I'll open a PR soon! Just doing some profiling

@grjte
Copy link
Contributor

grjte commented Oct 22, 2024

@saleel I have branches ready to 1) add support for optional padding and 2) add base64url support, which is a very small follow-up once the optional padding is done. They both work off of the formatting fix PR I opened last week #18, so I can open a PR once that one (or a similar fix) is merged.

I do have one point of confusion where I could really use a sanity check - I ran bb gates over encode/decode with the current version (on main), the version with optional padding and the version with base64url. According to my results, the costs don't change between them (which is what I expect, if globals are only executed when they're used rather than when they're declared), but it also shows a different result for the current main version than when I tested to update the README previously, so I made a profiling error at some point. It'd be really helpful to get feedback here if you have a chance to look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants