Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverse slash direction in StdLibAssets prefix on windows #992

Merged

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #981

Description

Summary of changes

We now reverse the slash direction for the prefix associated with StdLibAssets on windows. This ensures that the path std/lib.nr matches this once it has converted into a PathBuf and back turning it into std\lib.nr

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench requested a review from kobyhallx March 16, 2023 11:18
@TomAFrench TomAFrench enabled auto-merge March 16, 2023 11:43
@TomAFrench TomAFrench added this pull request to the merge queue Mar 16, 2023
Merged via the queue into noir-lang:master with commit 65b7108 Mar 16, 2023
@TomAFrench TomAFrench deleted the platform-specific-embed-prefix branch March 16, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

called Option::unwrap() on a None value
2 participants