Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit usage of noirpacker.py #951

Closed
kevaundray opened this issue Mar 6, 2023 · 1 comment · Fixed by #987
Closed

Revisit usage of noirpacker.py #951

kevaundray opened this issue Mar 6, 2023 · 1 comment · Fixed by #987
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

In the past, we had the problem of the noir-wasm not being able to read multiple files in the browser without a file-read host function.

A file-read host function was then added, however we also desired the stdlib to be added automatically without the file-read host function. Since the stdlib spanned multiple files, this was not possible and so Jake created noirpacker which allowed us to pack the stdlib into one file by inlining each module declaration.

This functionality is actually still quite useful and is close to what javascript minify does.

This issue is left as a tracker to decide on whether we still need it for the original problem.

CC @ko

Proposed solution

A solution would detail a narrative on how the stdlib will be loaded in the browser.

Alternatives considered

No response

Additional context

We can also bring it back for the web context in the future, so that users can minify their source code. We would need t add compression and whitespace removal etc

@TomAFrench
Copy link
Member

Looks like this isn't necessary after #973. I'd say that we can delete it for now and resurrect it for the minifier usecase down the line if we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants