Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: read-only array #899

Merged
merged 54 commits into from
Mar 23, 2023
Merged

feat: read-only array #899

merged 54 commits into from
Mar 23, 2023

Conversation

guipublic
Copy link
Contributor

@guipublic guipublic commented Feb 22, 2023 •
edited
Loading

Description

Summary of changes

Detect when an array is read-only so that fewer constraints are generated

Dependency

This PR relies on the dynamic array indexing PR #886 and must be merged after.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

We should be able to use read-only arrays with barretenberg turbo-plonk implementation.

jfecher
jfecher reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR contains changes from the dynamic indexing PR. Is it required?

@guipublic
Copy link
Contributor Author

Looks like this PR contains changes from the dynamic indexing PR. Is it required?

Yes, I have updated the description to indicate that it should be merged after the dynamic indexing PR.

@guipublic guipublic requested a review from jfecher March 21, 2023 11:23
@guipublic
Copy link
Contributor Author

The PR can now be reviewed as #886 is merged

@guipublic guipublic requested a review from jfecher March 23, 2023 13:31
jfecher
jfecher approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jfecher
jfecher requested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting fixes to the typo Tom caught and a small simplification

jfecher
jfecher approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping up with all the small suggestions. Apologies it took so many rounds

@guipublic guipublic enabled auto-merge March 23, 2023 14:21
@guipublic
Copy link
Contributor Author

Thanks for keeping up with all the small suggestions. Apologies it took so many rounds

np, as long as you keep being reactive, it's fine!

@guipublic guipublic added this pull request to the merge queue Mar 23, 2023
Merged via the queue into master with commit 2e38ab0 Mar 23, 2023
@guipublic guipublic deleted the gd/dynamic_array6 branch March 23, 2023 15:09
@kevaundray kevaundray mentioned this pull request Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench left review comments

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guipublic @jfecher @TomAFrench