Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ACIR checksum from using Sha to a faster checksum #870

Closed
vezenovm opened this issue Feb 17, 2023 · 0 comments · Fixed by #1094
Closed

Move ACIR checksum from using Sha to a faster checksum #870

vezenovm opened this issue Feb 17, 2023 · 0 comments · Fixed by #1094
Labels
enhancement New feature or request

Comments

@vezenovm
Copy link
Contributor

Problem

The move to preprocess has reduced the proving and verification times for several circuits. Times can be referenced here (#765)

We currently take a Sha256 checksum to see whether the circuit someone is trying to prove differs from the one for which keys were generated. However, if you look at the timing in the PR linked above, for larger circuits hashing the circuit before every prove does cause some slowdown.

Solution

Move to a faster checksum mechanism such as this: https://github.com/srijs/rust-crc32fast

Alternatives considered

It would also be good to add some sort of unchecked flag. An experienced dev who is confident can avoid the check then and reduce the time of a call to nargo prove

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant