chore!: Make abi field non-optional in CompiledProgram
#856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #855
Description
Summary of changes
We don't get any benefit to allowing
CompiledProgramto be created without an ABI as we always unwrap it. We then require the ABI to be included which allows us to remove repeated boilerplate to extract the ABI from theCompiledProgramThis revealed that we didn't need to clone the ABI in a number of places when reading in inputs so we can instead just borrow it from the
CompiledProgram.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Additional context