-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlib): Add higher order array functions #833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
changed the title
Add higher order array functions
feat(stdlib): Add higher order array functions
Feb 13, 2023
From slack: This is blocked by 618 |
@kevaundray this is not blocked by #618, I've removed the for each loops in favor of normal for loops. |
jfecher
commented
Feb 14, 2023
Ah sorry, an obvious oversight on my part, re the for loops |
kevaundray
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #831
Description
Adds some higher order array functions to the stdlib.
Summary of changes
Adds:
,std::array::map
map
has been removed as we would need to support the syntax[expr; comptime expr]
where we can initialize an array of any comptime length. Today it is limited to only integer literals or globals rather than any length expression.std::array::fold
std::array::reduce
- like fold but uses the first element in the array as the accumulator value.std::array::find
find
has also been removed. The negative numbers seemed to cause issues that prevented proving/verification.std::array::sort_via
std::array::all
std::array::any
Test additions / changes
Tests these functions in the higher_order_functions test.
Checklist
cargo fmt
with default settings.