Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noir-lang/big_curve test test_secp256r1_offset_generators fails after #6685 #6763

Closed
TomAFrench opened this issue Dec 10, 2024 · 2 comments · Fixed by #6778 or #6958
Closed

noir-lang/big_curve test test_secp256r1_offset_generators fails after #6685 #6763

TomAFrench opened this issue Dec 10, 2024 · 2 comments · Fixed by #6778 or #6958
Assignees

Comments

@TomAFrench
Copy link
Member

While fixing the dead canary @kashbrti found in noir-lang/noir_bigcurve#22 that the test_secp256r1_offset_generators would fail with the error

error: Failed to solve program: 'Failed to solve brillig function'
   ┌─ /mnt/user-data/tom/nargo/github.com/noir-lang/noir-bignumv0.4.2/src/fns/expressions.nr:74:12
   │
74 │     assert(remainder == [0; N]);
   │            -------------------
   │
   = Call stack:
     1. src/bigcurve_test.nr:534:17
     2. src/lib.nr:331:9
     3. src/lib.nr:772:13
     4. src/lib.nr:380:9
     5. /mnt/user-data/tom/nargo/github.com/noir-lang/noir-bignumv0.4.2/src/bignum.nr:264:9
     6. /mnt/user-data/tom/nargo/github.com/noir-lang/noir-bignumv0.4.2/src/fns/expressions.nr:279:9
     7. /mnt/user-data/tom/nargo/github.com/noir-lang/noir-bignumv0.4.2/src/fns/expressions.nr:74:12

I've bisected this down to passing on fc11b63 and failing on 24cc19e so it seems like the root cause is due to us not copying arrays when we should due to the changes made in #6685.

We didn't catch this at the time as the tests in noir_bignum were already failing in CI due to being too heavy for the github runner to run in parallel.

@TomAFrench
Copy link
Member Author

@jfecher Can you take a look at whether we can salvage #6685 or if it needs to be reverted?

@TomAFrench TomAFrench mentioned this issue Dec 11, 2024
5 tasks
@jfecher
Copy link
Contributor

jfecher commented Dec 11, 2024

Looking into this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
2 participants