Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for circuit solvability at the end of compilation. #6389

Closed
TomAFrench opened this issue Oct 29, 2024 · 0 comments · Fixed by #6415
Closed

Add a check for circuit solvability at the end of compilation. #6389

TomAFrench opened this issue Oct 29, 2024 · 0 comments · Fixed by #6415
Assignees

Comments

@TomAFrench
Copy link
Member

We're currently getting a situation where some aztec contracts are having missing witness assignments: AztecProtocol/aztec-packages#9488

As a final compilation step we should add a check where we ensure that all opcodes are solvable. Starting from the known set of input witnesses we can ensure that all inputs are known for each opcode by the time we reach it, adding the outputs of that opcode to the new set of known witnesses.

This will ensure that there's continuity in the ACIR circuits we generate without needing to know the inputs.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 29, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants