Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::hash::keccak256 cannot hash more than a single block (136 bytes input) #6130

Closed
Tracked by #6193
TomAFrench opened this issue Sep 23, 2024 · 1 comment · Fixed by #6393
Closed
Tracked by #6193

std::hash::keccak256 cannot hash more than a single block (136 bytes input) #6130

TomAFrench opened this issue Sep 23, 2024 · 1 comment · Fixed by #6393
Assignees
Labels
bug Something isn't working

Comments

@TomAFrench
Copy link
Member

std::hash::keccak256 is currently written implying that it will support inputs of multiple blocks however attempting to provide inputs in excess of 136 bytes will fail as we attempt to write them into an array with the capacity to hold only a single block.

We should add testing for multi-block hash inputs and fix this issue.

@TomAFrench TomAFrench added the bug Something isn't working label Sep 23, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 23, 2024
@Savio-Sou
Copy link
Collaborator

Also reported on Noir Discord: https://discord.com/channels/1113924620781883405/1292163282345656320/1292163282345656320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants