Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brillig codegen sometimes initialises unused boolean constants #5952

Open
TomAFrench opened this issue Sep 6, 2024 · 0 comments
Open

Brillig codegen sometimes initialises unused boolean constants #5952

TomAFrench opened this issue Sep 6, 2024 · 0 comments
Labels
brillig Unconstrained functions / brillig IR optimization

Comments

@TomAFrench
Copy link
Member

It seems like the constant liveness analysis for brillig (AztecProtocol/aztec-packages#8294) doesn't play nicely with the optimisation on boolean constraints added in #5919. The former sees that it needs to allocate a constant u1 1 to perform the equality with however we then don't use that constant.

This causes some degradation in #5951.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 6, 2024
@TomAFrench TomAFrench added optimization brillig Unconstrained functions / brillig IR labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brillig Unconstrained functions / brillig IR optimization
Projects
Noir
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomAFrench