Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalar multiplication should account for zeros from MSB end #5259

Closed
skaunov opened this issue Jun 16, 2024 · 0 comments
Closed

scalar multiplication should account for zeros from MSB end #5259

skaunov opened this issue Jun 16, 2024 · 0 comments

Comments

@skaunov
Copy link

skaunov commented Jun 16, 2024

noir/noir_stdlib/src/ec/swcurve.nr

Line 339 in d9b4712

fn bit_mul<N>(self, bits: [u1; N], p: Point) -> Point {

noir/noir_stdlib/src/ec/swcurve.nr

Line 352 in d9b4712

pub fn mul(self, n: Field, p: Point) -> Point {

Currently it will double the point N times even when multiplying by $1$.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 16, 2024
@guipublic guipublic mentioned this issue Jun 18, 2024
Closed
5 tasks
@TomAFrench TomAFrench closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix scalar mul in stdlib/ec noir-lang/noir
2 participants
@TomAFrench @skaunov