Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get different contract-method name on codegen-verifier #4977

Closed
hpmaxi opened this issue May 4, 2024 · 1 comment
Closed

Get different contract-method name on codegen-verifier #4977

hpmaxi opened this issue May 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@hpmaxi
Copy link

hpmaxi commented May 4, 2024

Problem

When trying to deploy a contract generated by codegen-verifier, if more than one was generated for different verification tasks, the next command fails because of this

await viem.deployContract('UltraVerifier');

I think, that in case of receiving an argument, should be interpolated here.

Happy Case

Have a way to rename the target contract/method

Project Impact

Nice-to-have

Impact Context

No response

Workaround

Yes

Workaround Description

Use the fully qualified path/name

await viem.deployContract('contract/folder/plonk_vk.sol:UltraVerifier');

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@hpmaxi hpmaxi added the enhancement New feature or request label May 4, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 4, 2024
@Savio-Sou
Copy link
Collaborator

Thanks for submitting the Issue!

As codegen-verifier is largely a proving backend / barretenberg binary feature which we're moving towards unwrapping it from Nargo, I'd recommend recreating this Issue in the Barrtenberg repo: https://github.com/AztecProtocol/barretenberg

@hpmaxi hpmaxi closed this as completed May 6, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants