Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI task to check compilation using non-bn254 curve #4752

Open
TomAFrench opened this issue May 30, 2023 · 0 comments
Open

Add CI task to check compilation using non-bn254 curve #4752

TomAFrench opened this issue May 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

We've had a few issues with default feature flags preventing us from compiling using curves other than bn254 (see noir-lang/acvm#225).

Happy Case

We should enforce that we can always activate and compile using a different field. This can be done simply with a CI workflow which just attempts to compile using the different feature flags.

As we're only testing that we're not setting conflicting feature flags we can restrict this to run in the situation where a Cargo.toml file has changed. (I'm discounting the situation where we make two originally non-mutually exclusive flags mutually exclusive)

Alternatives Considered

We could run the entire test suite for the different feature flag combinations to ensure that ACVM works as expected using different curves (e.g. using something like https://github.com/frewsxcv/cargo-all-features). This is overkill however in my mind.

Additional Context

No response

Would you like to submit a PR for this Issue?

Maybe

Support Needs

No response

@TomAFrench TomAFrench added the enhancement New feature or request label May 30, 2023
@TomAFrench TomAFrench transferred this issue from noir-lang/acvm Apr 9, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant