You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've had a few issues with default feature flags preventing us from compiling using curves other than bn254 (see noir-lang/acvm#225).
Happy Case
We should enforce that we can always activate and compile using a different field. This can be done simply with a CI workflow which just attempts to compile using the different feature flags.
As we're only testing that we're not setting conflicting feature flags we can restrict this to run in the situation where a Cargo.toml file has changed. (I'm discounting the situation where we make two originally non-mutually exclusive flags mutually exclusive)
Alternatives Considered
We could run the entire test suite for the different feature flag combinations to ensure that ACVM works as expected using different curves (e.g. using something like https://github.com/frewsxcv/cargo-all-features). This is overkill however in my mind.
Additional Context
No response
Would you like to submit a PR for this Issue?
Maybe
Support Needs
No response
The text was updated successfully, but these errors were encountered:
Problem
We've had a few issues with default feature flags preventing us from compiling using curves other than bn254 (see noir-lang/acvm#225).
Happy Case
We should enforce that we can always activate and compile using a different field. This can be done simply with a CI workflow which just attempts to compile using the different feature flags.
As we're only testing that we're not setting conflicting feature flags we can restrict this to run in the situation where a
Cargo.toml
file has changed. (I'm discounting the situation where we make two originally non-mutually exclusive flags mutually exclusive)Alternatives Considered
We could run the entire test suite for the different feature flag combinations to ensure that ACVM works as expected using different curves (e.g. using something like https://github.com/frewsxcv/cargo-all-features). This is overkill however in my mind.
Additional Context
No response
Would you like to submit a PR for this Issue?
Maybe
Support Needs
No response
The text was updated successfully, but these errors were encountered: