Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe Driver's check method could be skipped given that now it is a pass through method #456

Closed
ilitteri opened this issue Nov 9, 2022 · 2 comments · Fixed by #728
Closed

Maybe Driver's check method could be skipped given that now it is a pass through method #456

ilitteri opened this issue Nov 9, 2022 · 2 comments · Fixed by #728
Labels
enhancement New feature or request

Comments

@ilitteri
Copy link
Contributor

ilitteri commented Nov 9, 2022

I think that this issue requires a discussion label

This issue is to track this note and was requested here.

Problem

After #443 the build of the Driver is like a passthrough method.

Solution

Make analyze_crate public and use it instead of build (removing it).

Alternatives considered

  • Move the analyze_crate logic into build.
  • This could also stay like it is the idea of this issue is to discuss it.

Additional context

N/A
@ilitteri ilitteri added the enhancement New feature or request label Nov 9, 2022
@kevaundray
Copy link
Contributor

Related to @jfecher issue about renaming build to check

@TomAFrench TomAFrench changed the title Maybe Driver's build method could be skipped given that now it is a pass through method Maybe Driver's check method could be skipped given that now it is a pass through method Feb 3, 2023
@TomAFrench TomAFrench linked a pull request Feb 3, 2023 that will close this issue
feat(nargo): Add nargo test command to run all unit tests #728
Merged
9 tasks
@jfecher
Copy link
Contributor

jfecher commented Feb 3, 2023

The test PR had to reorganize this slightly and I ended up just deleting the wrapper function entirely there. Once that PR is merged this issue can be closed

@jfecher jfecher closed this as completed Feb 3, 2023
@jfecher jfecher reopened this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nargo): Add nargo test command to run all unit tests noir-lang/noir
3 participants
@jfecher @kevaundray @ilitteri