Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hex encoded field elements in Prover.toml > u128 throws w/ unhelpful message #3436

Open
colinnielsen opened this issue Nov 6, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@colinnielsen
Copy link

Aim

When:

  • Passing Field elements as hex-encoded numbers
  • Passing Field elements as integers
Screenshot 2023-11-06 at 1 43 04 PM

What:
Since the target type is > u120, the toml parser crashes.
Screenshot 2023-11-06 at 1 39 50 PM

Workaround:
Stringify the inputs

Screenshot 2023-11-06 at 1 41 33 PM

Expected Behavior

Nargo should parse the inputs as big integers OR have a the error message ask the user to stringify fields.

Bug

.

To Reproduce

  1. git clone [email protected]:colinnielsen/noir-field-parsing.git
  2. cd noir-field-parsing
  3. nargo execute

Installation Method

Binary

Nargo Version

0.17.0+b6819f6261e63cea3e653a1b874727a2b5919f5e

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@colinnielsen colinnielsen added the bug Something isn't working label Nov 6, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 6, 2023
@kevaundray kevaundray added the good first issue Good for newcomers label Jan 15, 2024
@kevaundray kevaundray added this to the 0.25 milestone Jan 15, 2024
@Savio-Sou Savio-Sou removed this from the 0.25 milestone Feb 23, 2024
@Savio-Sou
Copy link
Collaborator

Possibly similar to #2456 (comment), where the culprit was TOML can only hold numeric values up to i64; anything larger needs to be a hex / string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants