Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pub(crate) visibility #3168

Closed
guipublic opened this issue Oct 16, 2023 · 1 comment · Fixed by #3271
Closed

Add pub(crate) visibility #3168

guipublic opened this issue Oct 16, 2023 · 1 comment · Fixed by #3271
Assignees
Labels
enhancement New feature or request

Comments

@guipublic
Copy link
Contributor

guipublic commented Oct 16, 2023

Problem

We support the pub attribute when defining a function, so that the function is visible everywhere externally and internally.

We could extend it with the pub(crate) notation which would allow the function to be used inside the crate, but not in an external crate.

Happy Case

pub(crate) makes a function visible within the current crate.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@guipublic guipublic added the enhancement New feature or request label Oct 16, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 16, 2023
@kevaundray
Copy link
Contributor

Also tagging along pub(crate) and pub for structures, but we may want this in another issue

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants