Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather feedback about solidity verifier output paths #2108

Closed
phated opened this issue Aug 1, 2023 · 5 comments
Closed

Gather feedback about solidity verifier output paths #2108

phated opened this issue Aug 1, 2023 · 5 comments
Assignees

Comments

@phated
Copy link
Contributor

phated commented Aug 1, 2023

In #1992, we changed the file path locations output by the codegen-verifier command to be <root>/contract/<package_name>/plonk_vk.sol.

We are seeking feedback on this change. Does this layout make sense? Would something else be better?

@Savio-Sou
Copy link
Collaborator

cc @critesjosh @signorecello in case if you guys have any thoughts

@critesjosh
Copy link
Contributor

I think this is a fine default location. It would be cool if it could be customized, so the user can specify the location with a --path flag or something.

@TomAFrench
Copy link
Member

Why do we use the filename plonk_vk.sol? Would <root>/contract/<package_name>.sol be preferable?

@phated
Copy link
Contributor Author

phated commented Aug 4, 2023

Why do we use the filename plonk_vk.sol? Would <root>/contract/<package_name>.sol be preferable?

Tom and I discussed this a bit over a call and we think the package name should be used for a directory because some verifiers can contain multiple files (such as https://github.com/AztecProtocol/barretenberg/tree/master/sol)

@TomAFrench
Copy link
Member

That said, plonk_vk.sol is a pretty bad name and could be improved imo

@TomAFrench TomAFrench removed their assignment Aug 8, 2023
@phated phated removed their assignment Aug 8, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants