-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gather feedback about solidity verifier output paths #2108
Comments
cc @critesjosh @signorecello in case if you guys have any thoughts |
I think this is a fine default location. It would be cool if it could be customized, so the user can specify the location with a --path flag or something. |
Why do we use the filename |
Tom and I discussed this a bit over a call and we think the package name should be used for a directory because some verifiers can contain multiple files (such as https://github.com/AztecProtocol/barretenberg/tree/master/sol) |
That said, |
In #1992, we changed the file path locations output by the
codegen-verifier
command to be<root>/contract/<package_name>/plonk_vk.sol
.We are seeking feedback on this change. Does this layout make sense? Would something else be better?
The text was updated successfully, but these errors were encountered: