Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nargo)!: Make proving and verification keys optional #1880

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

kevaundray
Copy link
Contributor

Description

The proving and verifying keys are quite large, so now we give users the option to include or not include those keys.

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the title chore!(nargo): Make proving and verification keys optional chore(nargo)!: Make proving and verification keys optional Jul 6, 2023
@ludamad
Copy link
Collaborator

ludamad commented Jul 7, 2023

78vtj
LGTM

@kevaundray kevaundray marked this pull request as ready for review July 7, 2023 10:25
@kevaundray kevaundray added this pull request to the merge queue Jul 7, 2023
Merged via the queue into master with commit be36c1e Jul 7, 2023
@kevaundray kevaundray deleted the kw/optional-proving-key branch July 7, 2023 10:53
@Savio-Sou
Copy link
Collaborator

Should we document this? (Are we expecting end users to make use of it?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants