fix(ssa refactor): Prevent stores in 'then' branch from affecting the 'else' branch #1827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #1826
Summary*
Previously, any stores in the
then
branch of anif
would be picked up by theelse
branch as well (See the linked issue for more details). This PR adds an extra step to the flattening pass to restore the old values of each store between the then and else branches to fix this.I've also altered the
merge_stores_with_offset
test since we no longer support offsets from allocations after the switch to immutable arrays. I changed the test to a simple merge stores test but with an else block.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.