Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Methods called after being passed through a generic type were not being detected #1785

Merged
merged 5 commits into from
Jun 21, 2023
Merged

fix: Methods called after being passed through a generic type were not being detected #1785

merged 5 commits into from
Jun 21, 2023

Conversation

kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Jun 21, 2023 •
edited
Loading

Description

Problem*

Resolves #1784

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

Solution above was found by @jfecher

jfecher
jfecher approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevaundray kevaundray marked this pull request as ready for review June 21, 2023 20:49
@kevaundray kevaundray enabled auto-merge June 21, 2023 20:49
@kevaundray kevaundray added this pull request to the merge queue Jun 21, 2023
Merged via the queue into master with commit e560cd2 Jun 21, 2023
@kevaundray kevaundray deleted the kw/follow-bindings branch June 21, 2023 22:51
This was referenced Jun 21, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

@ludamad ludamad ludamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot call method on returned generic type.
3 participants
@kevaundray @ludamad @jfecher