Brillig linking could result in code segments being overwritten

[kevaundray]

Problem

See here

When we are linking two independent artifacts, it could be the case that their labels collide and one artifact overwrites the labels in another artifact.

A traditional linker may error here or in some cases just issue a warning.

Happy Case

We should provide an error here and in order to ensure that the labels are unique, we can add the function ID and possibly the name to the label, instead of just the basic block ID

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

[kevaundray]

This may be more helpful if it was stateful, ie when we are in a particular block, and we add a label, it will automatically prepend the function id and block. Then when you exit the block, you "pop off" that block from the label stack.

We may be able to get rid of relative jumps in that case, since we can just label everything

[kevaundray]

@sirasistant what is the status of this issue?

[sirasistant]

It was done in #1652, It didn't auto close because it was merged to a branch that we used as a batch merge to master. Closing this!