Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Brillig code to handle normal calls to other brillig functions and constrained functions #1608

Closed
kevaundray opened this issue Jun 8, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request refactor ssa

Comments

@kevaundray
Copy link
Contributor

Problem

Generate Brillig for the following code:

fn constrained_identity_func(y : u32) -> u32 {
  y
}

unconstrained fn inner(x : u32, y : u32) -> u32 {
 x + y
}

// Calls a constrained function and then calls an unconstrained function
unconstrained fn outer(x : u32, y : u32) -> u32 {
   let z = constrained_identity_func(y); 
   inner(x, z)
}

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added enhancement New feature or request refactor ssa labels Jun 8, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 8, 2023
@kevaundray
Copy link
Contributor Author

Internally in slack it was mentioned that we want to split this issue into sub issues:

  • unconstrained calling unconstrained
  • constrained calling unconstrained (This is already tested)
  • unconstrained calling constrained

@guipublic assigning unconstrained calling unconstrained task to you

@kevaundray
Copy link
Contributor Author

@sirasistant what is the status of this issue?

@sirasistant
Copy link
Contributor

Resolved by #1919

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor ssa
Projects
Archived in project
Development

No branches or pull requests

2 participants