Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect TOML for arrays in Prover #1173

Closed
1 task
SleepingShell opened this issue Apr 19, 2023 · 1 comment
Closed
1 task

Incorrect TOML for arrays in Prover #1173

SleepingShell opened this issue Apr 19, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@SleepingShell
Copy link

Aim

Correct TOML should be generated in the Prover.toml file when nargo check is ran.

Expected behavior

Correct TOML should be generated in the Prover.toml file for arrays. Currently, the output is "[]", whereas it should be [""].

Bug

Simply define an array input into main.

Example:

use dep::std;
fn main(root : pub Field, leaf : Field, index : Field, hash_path: [Field; 1]) {
    constrain std::merkle::check_membership(root, leaf, index, hash_path) == 1;
}

Prover.toml:

hash_path = "[]"
index = ""
leaf = ""
root = ""

To reproduce

  1. Use the above code, or other code that specifies an array input.
  2. Run nargo check
  3. See Prover.toml

Installation method

Binary

Nargo version

nargo 0.3.2 (git version hash: 29b1f7d, is dirty: false)

@noir-lang/noir_wasm version

No response

@noir-lang/barretenberg version

No response

@noir-lang/aztec_backend version

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@SleepingShell SleepingShell added the bug Something isn't working label Apr 19, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 19, 2023
@TomAFrench
Copy link
Member

Hey @SleepingShell, this is addressed in #1104. If you update to v0.4.0 then you'll have this behaviour.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants