Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add checks for nop #1160

Merged
merged 2 commits into from
Apr 17, 2023
Merged

fix: Add checks for nop #1160

merged 2 commits into from
Apr 17, 2023

Conversation

guipublic
Copy link
Contributor

Related issue(s)

Resolves #1144

Description

Summary of changes

Add checks for Nop instructions when merging blocks and creating Phi instructions from IF joins.
I also had to fix an incorrect assert in acir_gen for the tests to pass.

Test additions / changes

Added a regression integration test.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

@guipublic guipublic marked this pull request as ready for review April 17, 2023 15:40
@guipublic guipublic changed the title Add checks for nop fix: Add checks for nop Apr 17, 2023
@kevaundray kevaundray added this pull request to the merge queue Apr 17, 2023
Merged via the queue into master with commit 809b85f Apr 17, 2023
@kevaundray kevaundray deleted the gd/issue_1144 branch April 17, 2023 17:36
@kevaundray kevaundray mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal error: entered unreachable code
2 participants
@guipublic @kevaundray