This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(acvm)!: Add circuit: &Circuit to eth_contract_from_vk function signature
#420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
circuit: &Circuit to eth_contract_from_vk function signaturecircuit: &Circuit to eth_contract_from_vk function signature
TomAFrench
reviewed
Jul 10, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
circuit: &Circuitto theeth_contract_from_vkfunction signature in theSmartContracttrait for ACVM backendsProblem*
Halo2 Backend needs to know the number of public inputs to generate the smart contract verifier for proofs. With the ACVM backend API, there is currently no way to pass this value into
eth_contract_from_vk.Resolves: #411
Summary*
Minimal changes- see description
Will require that
acvm-backend-barretenbergpasses in the ACIR even though it doesn't need it:https://github.com/noir-lang/acvm-backend-barretenberg/blob/master/src/acvm_interop/smart_contract.rs#L12-L16
And that
nargosupplies the ACIR when callingeth_contract_from_vkfrom the backend:https://github.com/noir-lang/noir/blob/master/crates/nargo/src/ops/codegen_verifier.rs#L3-L9
Additional Context
NA
PR Checklist*
cargo fmton default settings.